Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hungarian translations, and hungarian number formatters #1501

Merged
merged 2 commits into from
May 9, 2024

Conversation

nkelemen18
Copy link
Contributor

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@@ -5,7 +5,7 @@ public class TimeSpanHumanizeTests
{
[Theory]
[Trait("Translation", "Google")]
[InlineData(366, "egy év")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain this change. egy év seems correct

Copy link
Contributor Author

@nkelemen18 nkelemen18 May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

This is because I have addedd the missing hungarian translations to the resource file. egy év is correct, when toWords is set to true, othervise the number will be number, not word (1 vs egy).

I created new test cases to verify the word representation of TimeSpans.

https://github.com/Humanizr/Humanizer/pull/1501/files#diff-6829957358e12fc8868dd8833601a3630bc4d27a0489053daa4d863c2459dc7dR612

@SimonCropp SimonCropp added this to the v3.0 milestone May 9, 2024
@SimonCropp SimonCropp merged commit f0e379d into Humanizr:main May 9, 2024
3 checks passed
@SimonCropp
Copy link
Collaborator

@nkelemen18 thanks

@clairernovotny can you deploy a new beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants