Improve PrependArticleSuffix perf

[SimonCropp]

v2.14.1

Method	Mean	Error	StdDev	Allocated
PrependArticleSuffix	426.9 ns	7.07 ns	6.61 ns	1.16 KB

v3.0.0

Method	Mean	Error	StdDev	Allocated
PrependArticleSuffix	152.8 ns	1.26 ns	1.18 ns	312 B

[hazzik]

The could be _The[1..], etc.

[hazzik]

Actually it seems that The and others are not needed at all.

[SimonCropp]

good idea. i applied the _The[1..]

are not needed at all.

they are used. we could use _The[1..] but the variables make the below code a little more readable

[hazzik]

I see that they are used:

if (append.EndsWith(The))
{
    var suffix = append[append.IndexOf(_The, StringComparison.CurrentCulture)..];
    inserted[i] = ToOriginalFormat(append, suffix);
}

But would not be that just an equivalent of the following?

if (append.EndsWith(_The))
{
    var suffix = append[append.IndexOf(_The, StringComparison.CurrentCulture)..];
    inserted[i] = ToOriginalFormat(append, suffix);
}

[hazzik]

Also... I think the code is not entirely correct:

append.IndexOf(_The, StringComparison.CurrentCulture) will find a first index of " The" instead of last. I think something like "The General Theory of Relativity" would be completely destroyed by this process.

[hazzik]

Expected: ["The General Theory of Relativity"]
Actual: ["Theory of Relativity The General"]

[hazzik]

1. suffix here is known to be " The". It does not make sense to try to extract it from the string.
2. append.IndexOf(_The, StringComparison.CurrentCulture) should be append.LastIndexOf(_The, StringComparison.CurrentCulture). Which is known to be append.Length - " The".Length
3. ToOriginalFormat(append, suffix) again does the same operation append.IndexOf(suffix, StringComparison.CurrentCulture)