Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant LangVersion #1325

Merged
merged 1 commit into from
Feb 12, 2024
Merged

remove redundant LangVersion #1325

merged 1 commit into from
Feb 12, 2024

Conversation

SimonCropp
Copy link
Collaborator

No description provided.

@SimonCropp
Copy link
Collaborator Author

well thats a bizarre failure

[xUnit.net 00:00:13.91]     DefaultStrategy_HoursApart [FAIL]
  Failed DefaultStrategy_HoursApart [3 ms]
  Error Message:
   Assert.Equal() Failure: Strings differ
            ↓ (pos 1)
Expected: "dans 12 heures"
Actual:   "demain"
            ↑ (pos 1)

@hazzik
Copy link
Member

hazzik commented Feb 12, 2024

well thats a bizarre failure

Just restart, I guess. I think it is flaky test which would fail if run in a certain time.

@SimonCropp
Copy link
Collaborator Author

@hazzik yep. agreed #1327

@SimonCropp SimonCropp merged commit 578d9fc into main Feb 12, 2024
3 checks passed
@SimonCropp SimonCropp deleted the remove-redundant-LangVersion branch February 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @hazzik