-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert TimeUnit to symbols #1106
Conversation
OK, this probably needs some discussion. 😊 I want to use localized versions of Humanizer/src/Humanizer/Bytes/ByteRate.cs Lines 51 to 78 in d073790
I assume that a general method to get a symbol from the |
[InlineData(TimeUnit.Day, "d")] | ||
[InlineData(TimeUnit.Week, "week")] | ||
[InlineData(TimeUnit.Month, "mo")] | ||
[InlineData(TimeUnit.Year, "a")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the a mean here? Not sure I've seen this before, is there an example you can point to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it from Wikipedia, which listed both "a" (per annum?) and "y" (per year) as possible versions in English. Will fix as discussed. 👍🏻
Thanks for the review! 🙂 |
Here is a checklist you should tick through before submitting a pull request:
dev
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures