Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Japanese single year translation #1082

Merged

Conversation

Cheesebaron
Copy link
Contributor

@Cheesebaron Cheesebaron commented Jun 7, 2021

Fixes #1049 Japanese single year translation.

I am not a native Japanese speaker, so would be nice to get a confirmation that this is actually the correct way to translate it.

@SimonCropp SimonCropp added this to the v3.0 milestone Feb 12, 2024
@SimonCropp
Copy link
Collaborator

thanks for the contribution

@SimonCropp SimonCropp enabled auto-merge (squash) February 12, 2024 11:15
@Cheesebaron
Copy link
Contributor Author

@SimonCropp let me know if this needs more work such as rebasing etc. Happy to do it.

@SimonCropp
Copy link
Collaborator

@Cheesebaron thanks. some tests need fixing

@Cheesebaron
Copy link
Contributor Author

I see that. Will commit a fix for it :)

auto-merge was automatically disabled February 12, 2024 13:41

Head branch was pushed to by a user without write access

@SimonCropp SimonCropp merged commit b09553e into Humanizr:main Feb 14, 2024
3 checks passed
@Cheesebaron Cheesebaron deleted the bugfix/gh1049-japanese-single-year branch February 14, 2024 12:18
@SimonCropp SimonCropp added the bug label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Years translation issue on Japanese - version 2.7.9 for C# .NET
3 participants