Add TimeSpan.ToAge() extension method

[louis-z]

• Introduce the "TimeSpanHumanize_Age" resource, which indicates how to format a humanized TimeSpan as an age expression, when the two differ.
• Add the Resources.TryGetResource() method, which tries to retrieve a resource for a given culture but without falling back on the default culture. This will allow us to define the "TimeSpanHumanize_Age" resource for en-US (aka the default culture), but not have other cultures fall back on that culture's resource.
• Add DefaultFormatter.TimeSpanHumanize_Age(), which resorts to Resources.TryGetResource() to determine how to express a TimeSpan as age. If no resource is found for the given culture, it will simply output the standard humanized TimeSpan as is. (For other cultures where standard TimeSpan and age expression differ, such as many germanic languages, "TimeSpanHumanize_Age" will eventually need to be defined. However, this is outside the scope of this PR.)
• Add tests for both English & 1 non-English (i.e. French) cultures

Fixes #968

Here is a checklist you should tick through before submitting a pull request:

• Implementation is clean
• Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
• No Code Analysis warnings
• There is proper unit test coverage
• If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
• There are very few or no comments (because comments shouldn't be needed if you write clean code)
• Xml documentation is added/updated for the addition/change
• Your PR is (re)based on top of the latest commits from the dev branch (more info below)
• Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
• Readme is updated if you change an existing feature or add a new one
• Run either build.cmd or build.ps1 and ensure there are no test failures

[hazzik]

I think it would be better if the addition of " old" is added through the resource rather than logic checking for a specific culture. Because it is not strictly unique to English to add "old" modifier to describe the age. It seems applies to some Germanic languages as well:

• Afrikaans/Dutch: twee jaar oud
• Danish/Norwegian: to år gammel
• Swedish: två år gammal
• German: zwei Jahre alt

[hazzik]

Ok, I've read some info about the hyphenated age. So, hyphenated age is an age adjective. These do exist in languages other than English, in my native Russian for example:

• пятидесятилетний мужчина - fifty-years-old man.

"летний" here means "years-old" and "пятидесяти" - is an age component.

Similar for German: "fünfzigjähriger"

So I think: we could accept the ToAge() extension as is and give a little more thought to ToHyphenatedAge() extension.

The points to consider:

• more appropriate name?
• how to support different languages?

[clairernovotny]

Why do we need both a new en and en-US resource package? One of them will be included in the main dlll as embedded resources; which one is it?

[louis-z]

Why do we need both a new en and en-US resource package? One of them will be included in the main dlll as embedded resources; which one is it?

I must admit I wasn't too sure about that myself... But if I modify the PR according to what I proposed here, then this question will become irrelevant, right? 😄

[louis-z]

Hey @clairernovotny & @hazzik

I finally decided to drop the implementation of the so-called hyphenated (aka noun or pre-noun modifier) age expression, as it was too controversial. Can we now agree on this simpler PR? If not, please advise so I may make the necessary changes to have this PR accepted and merged.

[louis-z]

@SimonCropp, do you think I should resurrect this PR, at least in its simplified form (refer to this comment)?

[SimonCropp]

@louis-z yeah i think a simpler implementation with a subset would be easier to get in

should we close this one for now?

[hazzik]

@louis-z could you please resolve conflicts and (re-)sign the cla?

[louis-z]

@louis-z yeah i think a simpler implementation with a subset would be easier to get in

should we close this one for now?

I rebased my branch, as per @hazzik's request. @SimonCropp, what do you think?

[SimonCropp]

@louis-z can you add an explanation of the feature to the readme

[louis-z]

@louis-z can you add an explanation of the feature to the readme

Done