Skip to content

fix: OPTIC-2093: Audio hotkeys for step back/forward missing #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2025

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Apr 25, 2025

This pull request introduces a minor enhancement to the AudioUltraWithSettings component by adding two missing hotkey settings for media navigation: stepping backward and stepping forward.

Enhancements to hotkey settings:

Screenshot 2025-04-25 at 3 28 12 PM

@github-actions github-actions bot added the fix label Apr 25, 2025
@bmartel bmartel requested a review from yyassi-heartex April 25, 2025 20:30
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3790263
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6811deebb44ba5000839c37d

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 3790263
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/6811deebe4f0f300089e2ffc

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3790263
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6811deeb0bfd1700086d63b5

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Apr 28, 2025

/fm sync

Workflow run

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (665f1b5) to head (93d0e4e).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7426      +/-   ##
===========================================
- Coverage    78.40%   78.39%   -0.01%     
===========================================
  Files          193      193              
  Lines        15624    15624              
===========================================
- Hits         12250    12249       -1     
- Misses        3374     3375       +1     
Flag Coverage Δ
pytests 78.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Apr 30, 2025

/fm sync

Workflow run

@bmartel bmartel merged commit f68405c into develop Apr 30, 2025
40 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-optic-2093 branch April 30, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants