fix: OPTIC-2016: Removing AntD reset to aid in UI consistency between page navigations #7420
+26,521
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
yyassi-heartex
approved these changes
Apr 24, 2025
farioas
requested changes
Apr 28, 2025
…atch errors when running standalone server for tests.
|
@bmartel Could you describe what are you actually doing in this PR, please? I see some script and even a docker changes. What's the reasoning behind this? |
|
@hlomzik the description I wrote is accurately why I'm doing this. AntD has no way to allow you to ignore the reset, so all of these changes are necessary to rip out the reset only code through a postinstall. The resulting file we end up using instead of the original AntD import (which has everything in it) we import this generated file which is AntD without the reset css. I gitignored the file as it is huge and went with a compiled step here. |
…nto fb-optic-2016
bmartel
commented
Apr 30, 2025
…conds slower than before and will be flakey otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because AntD does not allow for explicit imports of the components/utilities classes it uses, separate from its reset css, this PR is introducing a postinstall step to strip out the reset css and gitignore that resulting file. This stops the issue of having certain pages impeded by shifting styles like typography and other global considerations which causes unforeseen consistency issues and overall a lot of bugs.