fix: LEAP-1957: Fix implementation of readonly behavior for controls and audio regions #7412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced regression integration and e2e tests to ensure annotations in "view all" mode are non-editable. Covered use cases for Rating, Taxonomy, and Audio regions. Added a new helper for accessing the "view all" button in the ToolBar component.
Ensure that controls respect the `isReadOnly` property across components. - Enabled `isEditable` for Taxonomy and linked it to disabled prop. - Updated tests to verify readonly functionality. - Applied the `isReadOnly` check in AudioRegionModel, Rating control, and associated UI elements to restrict user interactions properly.
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gondragos
changed the title
hlomzik
reviewed
Apr 23, 2025
hlomzik
approved these changes
Apr 23, 2025
Gondragos
commented
Apr 23, 2025
|
/fm sync |
Refined conditions to handle `updateable` state across multiple interactions, adding ability to select region without editing it. - Removed unnecessary `updateable` checks for mouse events where not required. - Added conditional guardrails for edge dragging and region selection to ensure consistent behavior. - Simplified and enhanced readability of related conditional statements.
Introduce a new test to validate audio region selection functionality. - Added `audioPerRegionConfig` to support per-region choices. - Updated the test spec to verify selection and visibility of per-region choices in the UI.
…o fb-LEAP-1957/view-all-tests
bmartel
approved these changes
Apr 29, 2025
|
/git merge
|
hlomzik
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
This update addresses the need to enforce readonly functionality across components, ensuring that the
isReadOnlyproperty is respected as intended. Additionally, the features ensure that annotations in "view all" mode remain non-editable, improving the application's integrity.Solution
isReadOnlychecks across Rating controls, Taxonomy, and Audio regions, restricting user interactions appropriately.Testing
Risks
No significant risks have been identified, as this change enforces UI constraints without altering the core application logic.