feat: DIA-2142: Use the new Button component in LSO apps and libraries #7359
+2,289
−1,964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `buttonVariant` to apply button styles to different elements - Example of `buttonVariant` usage with `a` example
|
/fm sync |
|
/docker build
|
nick-skriabin
force-pushed
the
fb-dia-2142/new-button-lso
branch
from
81ab6f8 to
e7f7624
Compare
|
/docker build
|
|
/docker build
|
|
/fm sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on one main area: refactoring the
Buttoncomponent to use a shared library. Changes in this PR spread across entire LSO - LSO React App, Data Manager and Editor. Be careful while reviewing.Below is a summary of the most important changes:
Button Component Refactoring
Removed the custom
Buttoncomponent and its associated styles (Button.jsxandButton.scss) in favor of the shared@humansignal/uilibrary. This simplifies maintenance and ensures consistency across projects. [1] [2]Updated all references to the old
Buttoncomponent across multiple files (e.g.,Error.jsx,Form.jsx,HeidiTip.tsx,Modal.jsx,ModalPopup.jsx) to use the newButtonfrom@humansignal/ui. Adjusted props and styles to match the new component's API. [1] [2] [3] [4] [5]Removed the
Buttonexport from theindex.jsfile, as it is no longer part of the local codebase.