Fix payload for adding file references #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbl3rd
approved these changes
Mar 15, 2019
aaclan-ebi
approved these changes
Mar 15, 2019
samanehsan
force-pushed
the
se-fix-file-payload
branch
from
b40c90e
to
ad6c077
Compare
|
retest this please |
1 similar comment
|
retest this please |
When adding file references via the ingest API, the payload needs to nest the file schema under a "content" key.
samanehsan
force-pushed
the
se-fix-file-payload
branch
from
ad6c077
to
a15ff78
Compare
rexwangcc
approved these changes
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When adding file references via the ingest API, the payload needs to include the "fileName" and "content" keys (the file schema is nested under content).
Changes
Update the payload format for adding file references.
Review Instructions
nullin the submission envelope's file json: https://api.ingest.integration.data.humancellatlas.org/submissionEnvelopes/5c8bd4d766ad970007f40f67/filesPR Checklist
Please ensure the following when opening a PR:
Follow-up Discussions