-
Notifications
You must be signed in to change notification settings - Fork 6
Fix improper markdown #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix improper markdown #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DailyDreaming
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing this.
chmreid
added a commit
that referenced
this pull request
Aug 23, 2019
* master: (35 commits) Fix failing collections tests Add pagination response headers (closes #2287) Fix improper markdown (#2367) Fix 500 on delete nonexistent bundle, again (fixes #1918) (#2351) Add ttl to async db items. (#2363) DSS Operations: Checkout (#2366) Revert "DSS/Operations: Checkout (#2264)" (#2365) DSS/Operations: Checkout (#2264) remove hard-coded stage name in secrets tests (#2364) This pins pyyaml <= 5.1 for aws cli compatibility (#2348) Update like to security policy (#2361) Relax sync size limit (#2354) Add secrets management to dss-ops script (#2325) Schema typo fix (s/it/is) Assert we don't checkout to the main bucket (avoiding a sync error). (#2350) Revert "Fix 500 on delete nonexistent bundle (fixes #1918)" Fix 500 on delete nonexistent bundle (fixes #1918) Simplify release scripting (#2347) More informative release status (#2345) Dedicated Trufflehog CI/CD stage (#2342) ...
chmreid
added a commit
that referenced
this pull request
Sep 11, 2019
* fix improper markdown * make PR template more readable and navigable * make issue template more readable and navigable * fix improper markdown in contributing file * fix some improper markdown in daemons readmes * fix more improper markdown in dss notify readme
chmreid
added a commit
that referenced
this pull request
Sep 11, 2019
* master: (36 commits) Adding a document to explain the action and resource relationship for… (#2395) Requirements Update (#2410) Increase dss notify workers. (#2408) Revert "Bump httpie from 1.0.2 to 1.0.3 (#2397)" (#2401) Bump httpie from 1.0.2 to 1.0.3 (#2397) Fix flaky test: TestFileApi.test_file_get_checkout . (#2396) Add retries to verification in _test_gs_cache(). (#2372) Added details of notify intervals (#2368) Fix failing collections tests Add pagination response headers (closes #2287) Fix improper markdown (#2367) Fix 500 on delete nonexistent bundle, again (fixes #1918) (#2351) Add ttl to async db items. (#2363) DSS Operations: Checkout (#2366) Revert "DSS/Operations: Checkout (#2264)" (#2365) DSS/Operations: Checkout (#2264) remove hard-coded stage name in secrets tests (#2364) This pins pyyaml <= 5.1 for aws cli compatibility (#2348) Update like to security policy (#2361) Relax sync size limit (#2354) ...
chmreid
added a commit
that referenced
this pull request
Sep 23, 2019
* fix improper markdown * make PR template more readable and navigable * make issue template more readable and navigable * fix improper markdown in contributing file * fix some improper markdown in daemons readmes * fix more improper markdown in dss notify readme
chmreid
added a commit
that referenced
this pull request
Sep 23, 2019
* fix improper markdown * make PR template more readable and navigable * make issue template more readable and navigable * fix improper markdown in contributing file * fix some improper markdown in daemons readmes * fix more improper markdown in dss notify readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does a few things:
Most of the improper markdown looks fine on Github because Github's markdown rendering engine is more forgiving, but many docs look broken when viewed in any application/website that uses stock markdown syntax.