ziplink breaks since 5.0.8 & route names

[keineahnung2345]

In 7c6ddd4#diff-69fcc931d59c5d7ece28397a6444b359dc4a6d2169454a884b1b1ea894ed50c2, it uses url_helpers.more_preview_path to generate path instead.

Using RAILS_ENV=production rails routes -g more_preview to check routes:

      Prefix Verb URI Pattern                                                                   Controller#Action
more_preview GET  /attachments/more_preview/:id/index(.:format)                                 attachments#more_preview {:id=>/[a-z0-9\.\-_]+/, :format=>/[^.]+/}
  more_asset GET  /attachments/more_preview/:id(/*asset).:assetformat(.:format)                 attachments#more_asset {:asset=>/.*/, :id=>/[a-z0-9\.\-_]+/, :format=>/[^.]+/}
             GET  /projects/:id/repository/:repository_id/preview(/*path)@/index(.:format)      repositories#more_preview {:path=>/.*?/, :format=>/[A-Za-z0-9]+/}
             GET  /projects/:id/repository/:repository_id/:rev/preview(/*path)@/index(.:format) repositories#more_preview {:path=>/.*?/, :rev=>/[a-z0-9\.\-_]+/, :format=>/[A-Za-z0-9]+/}

And found that there are only 4 paths instead of 6 defined in config/routes.rb. It seems we need to add :as => to each path in config/routes.rb?

[HugoHasenbein]

Dear User, the config/routes.rb contains patterns, in which first match wins. Currently, I'm extremely busy. I'll have a look into it in the second week of June. best regards Stephan

…

Am 25.05.2023 um 11:37 schrieb keineahnung2345 ***@***.***>: In 7c6ddd4#diff-69fcc931d59c5d7ece28397a6444b359dc4a6d2169454a884b1b1ea894ed50c2 <7c6ddd4#diff-69fcc931d59c5d7ece28397a6444b359dc4a6d2169454a884b1b1ea894ed50c2>, it uses url_helpers.more_preview_path to generate path instead. Using RAILS_ENV=production rails routes -g more_preview to check routes: Prefix Verb URI Pattern Controller#Action more_preview GET /attachments/more_preview/:id/index(.:format) attachments#more_preview {:id=>/[a-z0-9\.\-_]+/, :format=>/[^.]+/} more_asset GET /attachments/more_preview/:id(/*asset).:assetformat(.:format) attachments#more_asset {:asset=>/.*/, :id=>/[a-z0-9\.\-_]+/, :format=>/[^.]+/} GET /projects/:id/repository/:repository_id/preview(/*path)@/index(.:format) repositories#more_preview {:path=>/.*?/, :format=>/[A-Za-z0-9]+/} GET /projects/:id/repository/:repository_id/:rev/preview(/*path)@/index(.:format) repositories#more_preview {:path=>/.*?/, :rev=>/[a-z0-9\.\-_]+/, :format=>/[A-Za-z0-9]+/} And found that there are only 4 paths instead of 6 defined in config/routes.rb. It seems we need to add :as => to each path in config/routes.rb? — Reply to this email directly, view it on GitHub <#75>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJWRDRBHMH4T2HSIMWKG5JTXH4R6RANCNFSM6AAAAAAYOSJ5IU>. You are receiving this because you are subscribed to this thread.