Skip to content

Conversation

@darkone23
Copy link

saw fix by @hakuro-jp in pull request

adapted db linking example from rdearman/LWT_Docker as mentioned at:

my guess is that @hakuro-jp had different environment variables and that is why it was working on their machine and not for @HugoFara - this pull request makes the default values explicit and incorporates @hakuro-jp's fix.

I also ran into some security issues from mariaDB which doesn't want to allow secured root accounts access via insecure sessions. I set the password to 'root' instead of 'abcxyz' which says "Yes I know root is insecure and I am not using a password". This is how it is done in the rdearman/LWT_Docker project.

It is nice to have the environment variables so people can override and make their installations more secure. In general the installation instructions include an insecure database with user root and password 'abcxyz' - but this docker setup is using mariaDB which does not like that behavior.

There could possibly be some kind of security advisory in the docs (in general the installation instructions requires a loosely secured database), I imagine it isn't too big an issue for most users.

cheers - thanks~

saw fix by @hakuro-jp in pull request
 - #79

adapted db linking example from rdearman/LWT_Docker as mentioned at:
 - #37 (comment)
@HugoFara HugoFara linked an issue Dec 27, 2022 that may be closed by this pull request
@HugoFara HugoFara merged commit 2173722 into HugoFara:master Dec 27, 2022
@HugoFara
Copy link
Owner

I owe you a great one.

I tested your branch and it works well, cheers! Actually after much debug #79 would already be enough, but your pull request brings another layer of security.

I have spent several months trying to figure out how to use Docker and fix the issues with LWT. I finally tried again and gave up again with #79 . With your PR I got the motivation to do even more debug and finally it works! For the following generations, I ran into a nasty permission issue, which I will document elsewhere.

Cheers! 💯

@HugoFara HugoFara mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DB connect error when use docker

2 participants