add default values to docker installation - closes issue #37 #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saw fix by @hakuro-jp in pull request
adapted db linking example from rdearman/LWT_Docker as mentioned at:
my guess is that @hakuro-jp had different environment variables and that is why it was working on their machine and not for @HugoFara - this pull request makes the default values explicit and incorporates @hakuro-jp's fix.
I also ran into some security issues from mariaDB which doesn't want to allow secured root accounts access via insecure sessions. I set the password to 'root' instead of 'abcxyz' which says "Yes I know root is insecure and I am not using a password". This is how it is done in the rdearman/LWT_Docker project.
It is nice to have the environment variables so people can override and make their installations more secure. In general the installation instructions include an insecure database with user root and password 'abcxyz' - but this docker setup is using mariaDB which does not like that behavior.
There could possibly be some kind of security advisory in the docs (in general the installation instructions requires a loosely secured database), I imagine it isn't too big an issue for most users.
cheers - thanks~