Fix 66: enable session to pass testsql. #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the session isn't started, the logs show errors such as Undefined index: testwrong.
Author
|
Added another small commit to fix another similar thing with tests. |
HugoFara
added a commit
that referenced
this pull request
Nov 9, 2022
Some files were calling for $_SESSION superglobals, but no session. From an idea of PR #67.
Owner
|
Hi! Thanks for your PR, I did not merge it as I wanted to use another code already tested, but basically it does the same as yours. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session has to be set on both the sending (edit_texts) and receiving (do_tests) files.
PR into master b/c master is currently broken.