Fix deprecation warning #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi! I'm not sure why your Google Translate field was empty, but it was used internally to determine the two-character codes for languages, before sending requests to Google Translate. However, the ability to use the Google Translate API broke long ago (before I started contributing), so your bug fix is enough to get rid of the visual issues without disrupting the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
GoogleTranslate URIfield is left empty when editing a language, the field is set to null. At some point it the ability to givepreg_replace's third parameter a null value was deprecated, so this function call resulted in the Read view displaying a big