Skip to content

Fix cipher bytes#11

Merged
Hugo-C merged 2 commits into
masterfrom
fix-cipher-bytes
Dec 1, 2023
Merged

Fix cipher bytes#11
Hugo-C merged 2 commits into
masterfrom
fix-cipher-bytes

Conversation

@Hugo-C

@Hugo-C Hugo-C commented Nov 29, 2023

Copy link
Copy Markdown
Owner

Current method was inconsistent with the original implementation. We panic while the Python version set the count to the length of the list +1.

@codecov

codecov Bot commented Nov 29, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a9be21) 88.56% compared to head (ffe53e2) 89.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   88.56%   89.06%   +0.50%     
==========================================
  Files           2        2              
  Lines         376      375       -1     
==========================================
+ Hits          333      334       +1     
+ Misses         43       41       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hugo-C Hugo-C merged commit 76db0f5 into master Dec 1, 2023
@Hugo-C Hugo-C deleted the fix-cipher-bytes branch March 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant