[ Dev ⚗] Dev merge #15
Conversation
HueByte
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR merges a large set of changes including target framework and dependency updates to net9.0, extensive refactoring and improvements across test files and production services, and the adoption of new C# 12 syntax patterns consistent with recent language updates.
- Updated project files, package references, and migration snapshots to support net9.0 and newer dependency versions.
- Refactored and expanded test coverage for services such as Weather, Supervisor, and Conversation while modernizing coding patterns.
- Enhanced several production service implementations with improved error handling, logging, and maintainability.
Reviewed Changes
Copilot reviewed 135 out of 163 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Main.sln | Added solution items such as .editorconfig. |
| src/Jiro.Tests/* | Various test files updated for new dependency versions and expanded test coverage. |
| src/Jiro.Kernel/Jiro.Infrastructure/* | Updated migration snapshots and repository implementations. |
| src/Jiro.Kernel/Jiro.Core/* | Numerous service, model, command, and utilities updates including use of new C# syntax and updated logging/error-handling. |
| src/Jiro.Kernel/Jiro.Core/Options/* | Project options updated for dependency and target framework consistency. |
Files not reviewed (4)
- src/Jiro.Kernel/Jiro.Infrastructure/Migrations/20240817164704_ChatSessions.Designer.cs: Language not supported
- src/Jiro.Kernel/Jiro.Infrastructure/Migrations/20240817165129_ChatSessions_Clear.Designer.cs: Language not supported
- src/Jiro.Kernel/Jiro.Infrastructure/Migrations/20250613174948_session_adjustments.Designer.cs: Language not supported
- src/Jiro.Kernel/Jiro.Infrastructure/Migrations/20250613175025_refresh_token.Designer.cs: Language not supported
| var data = weather.Hourly.Time | ||
| .Zip(weather.Hourly.Temperature2m, (time, temp) => new { time, temp }) | ||
| .Zip(weather.Hourly.Rain, (prev, rain) => new { prev.time, prev.temp, rain }) | ||
| .Zip(weather.Hourly.Windspeed10m, (prev, windSpeed) => new WeatherGraphData | ||
| { | ||
| Date = prev.time, | ||
| Temperature = prev.temp, | ||
| Rain = prev.rain, | ||
| WindSpeed = windSpeed | ||
| }) | ||
| .Take(Math.Min(range, weather.Hourly.Time.Count)); |
There was a problem hiding this comment.
[nitpick] The chained Zip operations to combine weather data reduce readability. Consider extracting intermediate variables or using a loop to create a WeatherGraphData list, which will improve clarity and ease future maintenance.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
No description provided.