Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange for SmartThings IDE github integration #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

loverso
Copy link

@loverso loverso commented Oct 15, 2020

I rearranged the files and updated them so that this repo works in the SmartThings IDE github integration.

The basic change is to move the files from SmartThings/DeviceTypes to devicetypes/shackrat.
Each source has to be in a subdirectory named with ".src" and the filenames need to be all lowercase.
Each "name:" in the definition needs to match the filename (so I had to add "SmartThings" to each "name:").

@loverso
Copy link
Author

loverso commented Jan 22, 2021

I wrote:

Each "name:" in the definition needs to match the filename (so I had to add "SmartThings" to each "name:").

This is incorrect, as it causes the package name to not be what the code expects when it tries to add a new virtual device. I found this out last night when I tried to share a device from Hubitat=>ST and the device didn't up in ST, and there was an error in the live logging. I'm about to update this to remove "SmartThings" from each "name:" and to rename the files to remove that from the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant