This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Extended cache bust to custom checks #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored cache busting to support custom URLs along with an option to disable cache busting. Renamed cache bust param from ‘_’ to ‘cacheBust’ and added checking for preexisting parameters to avoid collisions.
|
this seems good to me. Could you rebase off master and re-run grunt? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored cache busting to support custom URLs along with option to disable cache busting.
I renamed cache bust param from
_tocacheBustand added checking for preexisting parameters to avoid collisions. I could use the location API to check for a duplicate 'cacheBust' parameter and support URLs with hashes. However, not having cache busting essentially breaks the custom URL functionality....