Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements 'do' tag for expression statements #240

Merged
merged 4 commits into from
Oct 11, 2018
Merged

Conversation

mattcoley
Copy link
Collaborator

@mattcoley mattcoley commented Oct 11, 2018

Requested feature: #197
Adds a do tag to evaluate an expression without printing out the result. Previously to evaluate an expression you would need to use {{ expression }}, however if this expression returned a value you were out of luck. Now you can do {% do expression %} without the side effects of what the result of expression returns.

@mattcoley mattcoley requested a review from boulter October 11, 2018 15:59
@codecov-io
Copy link

codecov-io commented Oct 11, 2018

Codecov Report

Merging #240 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
+ Coverage      71.6%   71.64%   +0.04%     
- Complexity     1375     1380       +5     
============================================
  Files           218      219       +1     
  Lines          4331     4338       +7     
  Branches        683      683              
============================================
+ Hits           3101     3108       +7     
  Misses          996      996              
  Partials        234      234
Impacted Files Coverage Δ Complexity Δ
...n/java/com/hubspot/jinjava/lib/tag/TagLibrary.java 81.81% <ø> (ø) 5 <0> (ø) ⬇️
...c/main/java/com/hubspot/jinjava/lib/tag/DoTag.java 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06ce761...6062639. Read the comment docs.

Copy link
Contributor

@boulter boulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattcoley mattcoley merged commit 00919cb into master Oct 11, 2018
@mattcoley mattcoley deleted the implement-do-tag branch October 11, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants