Skip to content

Task history handling when missing data #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssalinas merged 3 commits into from
Apr 8, 2022
Merged

Task history handling when missing data #2285

ssalinas merged 3 commits into from
Apr 8, 2022

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 8, 2022

Two main things here:

  • The history persister can race with task launches with selecting the list of active tasks to exclude from persisting
  • We should more thoroughly clean up tasks that don't have task data in zk

@ssalinas ssalinas added the staging Merged to staging branch label Apr 8, 2022
@pschoenfelder
Copy link
Contributor

pschoenfelder commented Apr 8, 2022

🚢

@ssalinas ssalinas merged commit 0b420cb into master Apr 8, 2022
@ssalinas ssalinas deleted the task_history_when_missing branch April 8, 2022 15:24
@ssalinas ssalinas added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

staging Merged to staging branch

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ssalinas @pschoenfelder