Avoid null next value in zk curator load distributor #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WH77
commented
Sep 23, 2021
|
|
||
| public CuratorFramework getCuratorFramework() { | ||
| return iterator.next(); | ||
| int ci = curatorIndex.getAndUpdate(i -> (i + 1) % curatorFrameworks.size()); |
Contributor
Author
There was a problem hiding this comment.
might've been able to get away without using an AtomicInteger here, but don't think it makes a huge difference either way
| ZooKeeperConfiguration zookeeperConfig = configuration.getZooKeeperConfiguration(); | ||
|
|
||
| if (configuration.isReadOnlyInstance()) { | ||
| LOG.trace("Creating multiple logging curator frameworks for read-only instance"); |
Contributor
There was a problem hiding this comment.
Might want to update this to reflect the actual value used in the line below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc - @pschoenfelder