Fix possible port collisions across tasks again #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks solid. How important are those TODO's in the unit tests? |
Contributor
Author
|
I don't believe they're the cause of the port allocation problem, they're more of a note that MesosUtils expects to be given valid resources to subtract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address the same issue as #2215.
Current logging hasn't uncovered a smoking gun, but there appears to a potential source of duplicated ports when offers are combined in SingularityOfferHolder. The most likely alternative cause would be stale offers in the cache, which would require a much heavier fix. For now, going to put this out there with additional logging around resource offers to help determine whether the cache or resource duplication is the root cause.