Throw exception to resubscribe to mesos #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalind210
changed the title
ssalinas
reviewed
Feb 5, 2021
...rityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosSchedulerClient.java
Outdated
Show resolved
Hide resolved
Member
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there's an issue connecting to Mesos master and the alert that went off was a Mesos4xxException, stating that the framework is no longer subscribed to master. When that happens, we want to throw an exception to be picked up by the
SingularityMesosSchedulerImplto pause and reconnect. This is done on a separate thread so as to not disrupt the current one.Unit tests check that the new function checkAndReconnect only attempts a reconnect when the exception is the correct exception.