Skip to content

Add method for guice bundle modification #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssalinas merged 1 commit into from
Sep 21, 2020
Merged

Add method for guice bundle modification #2132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions SingularityService/src/main/java/com/hubspot/singularity/SingularityService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ public void initialize(final Bootstrap<T> bootstrap) {
"getDropwizardConfiguredBundles() returned null"
);

guiceBundle =
GuiceBundle
.defaultBuilder(SingularityConfiguration.class)
.modules(getServiceModule(), getObjectMapperModule(), new SingularityAuthModule())
.modules(additionalModules)
.enableGuiceEnforcer(false)
.stage(getGuiceStage())
.build();
GuiceBundle.Builder<SingularityConfiguration> guiceBundleBuilder = GuiceBundle
.defaultBuilder(SingularityConfiguration.class)
.modules(getServiceModule(), getObjectMapperModule(), new SingularityAuthModule())
.modules(additionalModules)
.enableGuiceEnforcer(false)
.stage(getGuiceStage());
modifyGuiceBundle(guiceBundleBuilder);
guiceBundle = guiceBundleBuilder.build();
bootstrap.addBundle(guiceBundle);

bootstrap.addBundle(new CorsBundle());
Expand Down Expand Up @@ -185,6 +185,13 @@ public Iterable<? extends ConfiguredBundle<T>> getDropwizardConfiguredBundles(
return ImmutableList.of();
}

/**
* Allow for modification of GuiceBundle (e.g. injector factory settings)
*/
public void modifyGuiceBundle(
GuiceBundle.Builder<SingularityConfiguration> bundleBuilder
) {}

public static void main(final String[] args) throws Exception {
try {
new SingularityService<SingularityConfiguration>().run(args);
Expand Down