Filter getRequestHistory queries by createdAt times #2117
Conversation
| ); | ||
|
|
||
| @Override | ||
| default String getRequestHistoryBaseQuery() { |
There was a problem hiding this comment.
If this is just a constant let's declare it as a string on the class, not as a method, same for the mysql jdbi version
There was a problem hiding this comment.
The user column is named user in the mysql version, and f_user in the postgres version. That's why I didn't declare it as a constant.
There was a problem hiding this comment.
ah, totally read over that difference. It can still just be a String REQUEST_HISTORY_BASE_QUERY = "..."; on each class though, vs a method
There was a problem hiding this comment.
sry, read that again, ignore me...
|
Just the one comment on the static string vs method. Only other thing is to confirm that the history paging in the UI still seems to work as intended once deployed on staging 👍 , will give the ⛵ once you've tested there |
|
Tested on |
|
🚢 |
fabatef
changed the title
Instead of looping through the entire request history for some
requestIdto find theSingularityRequestHistorys in a specific time range, this change allows us to get the request history entries filtered bycreatedBeforeandcreatedAftertimes via SingularityClient#getHistoryForRequest