Skip to content

Don't truncate long request ids on details page #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WH77 merged 1 commit into from
Mar 10, 2020
Merged

Don't truncate long request ids on details page #2080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions SingularityUI/app/components/requestDetail/RequestHeader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,20 @@ const RequestHeader = ({requestId, group, deleted, showBreadcrumbs = true}) => {
<header className="detail-header">
{breadcrumbs}
<Row>
<Col md={7} lg={6}>
<Col md={6} lg={6}>
<RequestTitle requestId={requestId} deleted={deleted} />
</Col>
<Col md={5} lg={6} className="button-container">
<Col md={6} lg={6} className="button-container">
<RequestActionButtons requestId={requestId} />
</Col>
</Row>
<Row>
<Col md={12}>
<h2 className="request-title">
{requestId}
</h2>
</Col>
</Row>
<Row>
<Col md={12}>
<RequestAlerts requestId={requestId} deleted={deleted} />
Expand Down
3 changes: 0 additions & 3 deletions SingularityUI/app/components/requestDetail/header/RequestTitle.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ const RequestTitle = ({requestId, requestAPI, deleted}) => {
<h4>
{maybeInfo}
</h4>
<h2>
{Utils.maybe(requestAPI, ['data', 'request', 'id']) || requestId}
</h2>
</div>
);
};
Expand Down
4 changes: 4 additions & 0 deletions SingularityUI/app/styles/stylus/detailHeader.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

.detail-header

.request-title
white-space: normal
word-break: break-word

h1, h2, h3, h4, h5
margin-top 0
white-space nowrap
Expand Down