Subscribe on other thread for faster status updates #2030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
reviewed
Oct 30, 2019
|
|
||
| final Observable<Event> events = unicastEvents.share(); | ||
| final Observable<Event> events = unicastEvents.share() | ||
| .subscribeOn(subscribeScheduler); |
Contributor
There was a problem hiding this comment.
Is there any risk in having multiple events pertaining to the same Mesos host end up on two different subscriber threads simultaneously?
Member
Author
There was a problem hiding this comment.
I still need to stare at it more, but I don’t think so. Most of SchedulerImpl was written assuming it was already concurrent. Offer related traffic is behind a lock, as are any updates to state. Lost executors are mostly just logging. Status updates are a sync and behind request locks. Think that’s all?
Member
Author
|
One additional change, gave the offer-related events and status updates separate pools. It's possible we could get 4,5,6,etc offer events backed up and still block status updates if they aren't separated |
ssalinas
changed the title
configurable separate status update and offer pools subscribeOn -> observeOn move to avoid merge conflicts
ssalinas
force-pushed
the
subscribe_on_other
branch
from
9938cbe to
8781eba
Compare
Contributor
|
🚢 |
Member
Author
|
consolidating in #2032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found recently that most methods in SingularityMesosSchedulerImpl were all being processed on a single thread. For some things like status updates this is fine since they are then kicked over to another pool of threads. However for things like offers, we hog the thread for a while, making status updates very delayed. Let's use more than one thread....