Skip to content

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jul 18, 2019

In cases where the file name is like stdout there will be no extension. the Optional.or(null) will throw an error in that case, but we need the null value to differentiate things properly in the template

@ssalinas ssalinas added this to the 0.23.0 milestone Jul 18, 2019
@tpetr
Copy link
Contributor

tpetr commented Jul 18, 2019

🚢

@ssalinas ssalinas merged commit dd8e179 into master Jul 18, 2019
@ssalinas ssalinas deleted the executor_logrotate_extension branch July 18, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants