Update usage of Errorprone and also warnings

Add warnings for unused imports, star imports, and possible Android
incompatibilities.

Remove checkstyle!

buildSrc/src/main/groovy/rhino.library-conventions.gradle

@@ -1,7 +1,6 @@
 plugins {
     id 'rhino.java-conventions'
     id 'maven-publish'
-    id 'checkstyle'
     id 'jacoco'
     id 'net.ltgt.errorprone'
 }
@@ -50,6 +49,15 @@ tasks.withType(JavaCompile).configureEach {
         // This one either alerts for parameters that we don't use,
         // or spuriously for local variables in my opinion.
         "UnusedVariable")
+    options.errorprone.enable(
+        // These two do the last thing that Checkstyle used to do for us
+        "RemoveUnusedImports",
+        "WildcardImport",
+        // Warn us proactively that we are using things that might not work on Android.
+        // We will aggressively used "SuppressWarnings" for these, but these can be
+        // a reminder to check with an Android user since we don't have automated
+        // Android unit tests.
+        "AndroidJdkLibsChecker")
     options.errorprone.excludedPaths = '.+/src/test/java/.+'
 }
 

rhino-tools/src/main/java/org/mozilla/javascript/tools/shell/Global.java

@@ -398,6 +398,7 @@ public static Object doctest(Context cx, Scriptable thisObj, Object[] args, Func
         return global.runDoctest(cx, global, session, null, 0);
     }
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     public int runDoctest(
             Context cx, Scriptable scope, String session, String sourceName, int lineNumber) {
         doctestCanonicalizations = new HashMap<String, String>();
@@ -601,6 +602,7 @@ public static Object sync(Context cx, Scriptable thisObj, Object[] args, Functio
      *   <li><code>dir</code> - the working direcotry to run the commands.
      * </ul>
      */
+    @SuppressWarnings("AndroidJdkLibsChecker")
     public static Object runCommand(Context cx, Scriptable thisObj, Object[] args, Function funObj)
             throws IOException {
         int L = args.length;

rhino-tools/src/main/java/org/mozilla/javascript/tools/shell/JSConsole.java

@@ -24,6 +24,7 @@
 import javax.swing.UIManager;
 import org.mozilla.javascript.SecurityUtilities;
 
+@SuppressWarnings("AndroidJdkLibsChecker")
 public class JSConsole extends JFrame implements ActionListener {
     static final long serialVersionUID = 2551225560631876300L;
 

rhino/src/main/java/org/mozilla/javascript/JavaAdapter.java

@@ -319,6 +319,7 @@ private static Class<?> getAdapterClass(
         return adapterClass;
     }
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     public static byte[] createAdapterCode(
             Map<String, Integer> functionNames,
             String adapterName,

rhino/src/main/java/org/mozilla/javascript/JavaMembers.java

@@ -311,6 +311,7 @@ private Method[] discoverAccessibleMethods(
         return map.values().toArray(new Method[0]);
     }
 
+    @SuppressWarnings("deprecation")
     private void discoverAccessibleMethods(
             Class<?> clazz,
             Map<MethodSignature, Method> map,
@@ -656,6 +657,7 @@ private Constructor<?>[] getAccessibleConstructors(boolean includePrivate) {
         return cl.getConstructors();
     }
 
+    @SuppressWarnings("deprecation")
     private Field[] getAccessibleFields(boolean includeProtected, boolean includePrivate) {
         if (includePrivate || includeProtected) {
             try {
@@ -669,7 +671,7 @@ private Field[] getAccessibleFields(boolean includeProtected, boolean includePri
                     for (Field field : declared) {
                         int mod = field.getModifiers();
                         if (includePrivate || isPublic(mod) || isProtected(mod)) {
-                            field.trySetAccessible();
+                            if (!field.isAccessible()) field.setAccessible(true);
                             fieldsList.add(field);
                         }
                     }

rhino/src/main/java/org/mozilla/javascript/NativeDate.java

@@ -23,6 +23,7 @@
  *     <p>Significant parts of this code are adapted from the venerable jsdate.cpp (also Mozilla):
  *     https://dxr.mozilla.org/mozilla-central/source/js/src/jsdate.cpp
  */
+@SuppressWarnings("AndroidJdkLibsChecker")
 final class NativeDate extends IdScriptableObject {
     private static final long serialVersionUID = -8307438915861678966L;
 

rhino/src/main/java/org/mozilla/javascript/ScriptRuntime.java

@@ -3166,6 +3166,7 @@ public static Number multiply(Integer i1, Integer i2) {
         return Double.valueOf((double) r);
     }
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     public static Number exponentiate(Number val1, Number val2) {
         if (val1 instanceof BigInteger && val2 instanceof BigInteger) {
             if (((BigInteger) val2).signum() == -1) {
@@ -3225,6 +3226,7 @@ public static Number bitwiseXOR(Number val1, Number val2) {
         }
     }
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     public static Number leftShift(Number val1, Number val2) {
         if (val1 instanceof BigInteger && val2 instanceof BigInteger) {
             try {
@@ -3244,6 +3246,7 @@ public static Number leftShift(Number val1, Number val2) {
         }
     }
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     public static Number signedRightShift(Number val1, Number val2) {
         if (val1 instanceof BigInteger && val2 instanceof BigInteger) {
             try {

rhino/src/main/java/org/mozilla/javascript/SlotMap.java

@@ -17,6 +17,7 @@
  */
 public interface SlotMap extends Iterable<Slot> {
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     @FunctionalInterface
     public interface SlotComputer<S extends Slot> {
         S compute(Object key, int index, Slot existing);

rhino/src/main/java/org/mozilla/javascript/ThreadSafeSlotMapContainer.java

@@ -13,6 +13,7 @@
  * This class extends the SlotMapContainer so that we have thread-safe access to all the properties
  * of an object.
  */
+@SuppressWarnings("AndroidJdkLibsChecker")
 class ThreadSafeSlotMapContainer extends SlotMapContainer {
 
     private final StampedLock lock = new StampedLock();

rhino/src/main/java/org/mozilla/javascript/TokenStream.java

@@ -577,6 +577,7 @@ private static int stringToKeywordForES(String name, boolean isStrict) {
         return id & 0xff;
     }
 
+    @SuppressWarnings("AndroidJdkLibsChecker")
     private static boolean isValidIdentifierName(String str) {
         int i = 0;
         for (int c : str.codePoints().toArray()) {

rhino/src/main/java/org/mozilla/javascript/jdk18/VMBridge_jdk18.java

@@ -52,9 +52,13 @@ protected void setContext(Object contextHelper, Context cx) {
         storage[0] = cx;
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     protected boolean tryToMakeAccessible(AccessibleObject accessible) {
-        return accessible.trySetAccessible();
+        if (!accessible.isAccessible()) {
+            accessible.setAccessible(true);
+        }
+        return true;
     }
 
     @SuppressWarnings("deprecation")

rhino/src/test/java/org/mozilla/javascript/tests/Bug789277Test.java

@@ -520,6 +520,7 @@ private static AstRoot parseStrict(String source, ErrorReporter reporter, boolea
         return parser.parse(source, SOURCE_NAME, 1);
     }
 
+    @SuppressWarnings("deprecation")
     private static AstRoot parseStrict(Reader source, ErrorReporter reporter, boolean ide)
             throws IOException {
         Parser parser = new Parser(compilerEnv(reporter, ide));
@@ -544,6 +545,7 @@ public DataMap(Class<K> keyType) {
                 super(keyType);
             }
 
+            @SuppressWarnings("unchecked")
             public DataMap<K, V> putAll(V v, K... ks) {
                 for (K k : ks) {
                     put(k, v);

rhino/src/test/java/org/mozilla/javascript/tests/JavaIterableTest.java

@@ -24,6 +24,7 @@
 
 public class JavaIterableTest {
 
+    @SuppressWarnings("unchecked")
     @Test
     public void map() {
         Map<Object, Object> map = new LinkedHashMap<>();