Basic Amendment Frontend #1215
Open
Basic Amendment Frontend #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following cases are handled: 1. A vote is a main vote and has amendments -> amendment UI on ShowVotePage is shown. 2. A vote is not a main vote but /amendments is browsed -> 404 3. A vote is a main vote without amendments and /amendments is browsed -> 404
I am not sure why this is necessary in the first place, or rather, something goes wrong here. I checked both with `typeof` and both are strings, but the types say one is a number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a basic amendment frontend, similar to what we had in the old version.
All logic is handled in the frontend. This is not a problem for now, but will need to change once we want to polish this.
It looks like this (only if a vote has amendments):
The amendment page itself:
What I think would be nice: At least information about the authors and the outcome of an amendment vote directly on the amendment page itself. We cannot really give a lot of insights on an amendment right now, as we can make no statements about the contents. Thus, I think these two things could provide enough information to decide which amendment one wants to google. (Thinking out loud for a second, we could linkt to the text quite easily however I believe? Maybe directly on this page already and once more on the page of the amendment itself?). We could also think about showing small bars so that one can easily see which ones were close, as these might be of special interest.
All of this would however require to get more information than that currently available in
related.As usual, open to any design suggestions regarding how stuff looks.