Added C++ implementation #6

NazarPolonsky · 2017-06-06T20:28:53Z

Nazar Holickov IT-42

nechaido

Comment to the first file apply to every one of them. You should not use compiler specific features. Also this PR must include examples of std features like std::iterator and std::for_each.

nechaido · 2017-06-06T22:12:28Z

C++/1-for.cpp

+	{
+		cout << i << endl;
+	}
+	_getch();


I do not like the idea to use _geth() in here, if you think it is vital to get user input before ending the program - you could write an example runner.

nechaido · 2017-06-06T22:13:59Z

C++/1-for.cpp

+using namespace std;
+
+void For()
+{


We prefer to use Google C++ Style Guide, so the brace should stay on the same line.

nechaido · 2017-06-06T22:14:33Z

C++/1-for.cpp

+void For()
+{
+	for (int i = 0; i < 10; i++)
+	{


nechaido · 2017-06-06T22:20:16Z

C++/1-for.cpp

@@ -0,0 +1,14 @@
+#include "stdafx.h"


Is is really needed? I see no reason for this file to include "stdafx.h". Moreover it isn't even committed.

nechaido · 2017-06-06T22:28:52Z

C++/1-for.cpp

+
+void For()
+{
+	for (int i = 0; i < 10; i++)


Indentation must be made with 2 spaces not tabs.

nechaido · 2017-06-06T22:29:40Z

C++/8-forEach.cpp

+{
+	int arr[] = { 4, 2, 7, 8, 1, 6, 9, 5 };
+	int index = 0;
+	for each (int item in arr)


It is Visual C++ only. Moreover it is deprecated.

Iterates through an array or collection. This non-standard keyword is available in both C++/CLI and native C++ projects. However, its use is not recommended. Consider using a standard Range-based for Statement (C++) instead.

You should have used

for (auto item : arr)

aqrln · 2017-06-07T22:29:29Z

C++/1-for.cpp

+		cout << i << endl;
+	}
+	_getch();
+}


Missing newline at the end of file.

aqrln · 2017-06-07T22:29:36Z

C++/2-while.cpp

+		cout << index++ << endl;
+	}
+	_getch();
+}


Missing newline at the end of file.

aqrln · 2017-06-07T22:29:42Z

C++/3-doWhile.cpp

+	} while (index < 10);
+
+	_getch();
+}


Missing newline at the end of file.

aqrln · 2017-06-07T22:29:49Z

C++/4-forIn.cpp

+	}
+
+	_getch();
+}


aqrln · 2017-06-07T22:29:58Z

C++/6-break.cpp

+	cout << "There!";
+
+	_getch();
+}


aqrln · 2017-06-07T22:30:07Z

C++/7-continue.cpp

+	}
+
+	_getch();
+}


aqrln · 2017-06-07T22:30:14Z

C++/8-forEach.cpp

+	}
+
+	_getch();
+}


nechaido · 2018-10-17T10:37:49Z

Closed due to inactivity.

Added realization on C++

b41e584

Nazar Holickov IT-42

GYFK requested review from belochub and nechaido June 6, 2017 21:46

nechaido requested changes Jun 6, 2017

View reviewed changes

aqrln reviewed Jun 7, 2017

View reviewed changes

tshemsedinov changed the title ~~Added realization on C++~~ Added implementation on C++ Jun 21, 2017

tshemsedinov changed the title ~~Added implementation on C++~~ Added C++ implementation Jun 21, 2017

nechaido closed this Oct 17, 2018

Uh oh!

Added C++ implementation #6

Added C++ implementation #6

Uh oh!

Conversation

NazarPolonsky commented Jun 6, 2017

Uh oh!

nechaido left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nechaido Jun 6, 2017 • edited by belochub Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nechaido Jun 6, 2017 • edited by belochub Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nechaido Jun 6, 2017 • edited by belochub Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nechaido commented Oct 17, 2018

Uh oh!

Uh oh!

nechaido Jun 6, 2017 •

edited by belochub

Loading

nechaido Jun 6, 2017 •

edited by belochub

Loading

nechaido Jun 6, 2017 •

edited by belochub

Loading