feat(client): unhidden top banner #441
Conversation
WalkthroughThis change updates the promotional banner displayed in the application. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RootShellComponent
participant TopBannerComponent
User->>RootShellComponent: Loads application shell
RootShellComponent->>TopBannerComponent: Renders static event banner
TopBannerComponent-->>User: Displays Angular Spring Camp promotional banner
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
PR is detected, will deploy to dev environment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
libs/blog/shell/feature-shell-web/src/lib/root-shell.component.ts (2)
34-40: Banner carousel rendering commented out.The conditional rendering logic for the banner carousel has been commented out rather than removed.
If this change is intended to be permanent, consider removing the commented code rather than keeping it commented out to reduce code bloat and improve maintainability.
56-69: Slider store logic commented out.The computed properties and store related to the banner carousel have been commented out.
If this change is intended to be permanent, consider removing the commented code rather than keeping it commented out to improve code maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
libs/blog/ad-banner/ui/src/lib/top-banner.component.ts(1 hunks)libs/blog/shell/feature-shell-web/src/lib/root-shell.component.ts(4 hunks)
🔇 Additional comments (6)
libs/blog/ad-banner/ui/src/lib/top-banner.component.ts (1)
9-16: Banner updated with Angular Spring Camp 2025 information.The banner has been correctly updated to promote the Angular Spring Camp 2025 event, with appropriate UTM parameters for tracking in the URL and clear event details in the text.
libs/blog/shell/feature-shell-web/src/lib/root-shell.component.ts (5)
17-17: TopBannerComponent import added.Import for TopBannerComponent has been correctly added to the imports list.
23-23: Static top banner component added to template.The static top banner component has been added to replace the dynamic banner carousel.
Note: The template reference variable
#topBanneris defined but doesn't appear to be used elsewhere in the component.
52-52: TopBannerComponent added to component imports.TopBannerComponent has been properly added to the component's imports array, which is necessary for using it in the template.
74-74: adBannerVisible property still used but hardcoded to false.The
adBannerVisiblecomputed property is hardcoded tofalsebut is still used in the layout and viewport offset logic.Since the top banner is now visible, should
adBannerVisiblereturntrueinstead? This would affect the layout (mt-20class) and the viewport offset calculation in the effect.
101-101: Store data fetch commented out.The call to
sliderStore.getData()has been commented out, which is consistent with disabling the banner carousel functionality.
|
Deployed to dev environment |
DamianBrzezinskiHoA
force-pushed
the
feat/enable-top-banner
branch
from
02369c7 to
a1d3725
Compare
|
PR is detected, will deploy to dev environment |
DamianBrzezinskiHoA
changed the title
|
Deployed to dev environment |
Summary by CodeRabbit