This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix search 1438 #1451
Merged
Fix search 1438 #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master'
* Make search results filter on type. * Reduced size of new code. * Replace newline. * Reduce code size. * Fixed tests.
stukalin
approved these changes
Jun 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1438.
Changes proposed in this pull request:
The relational-pouch method parseRelDocs() doesn't filter based on the record type you give it. Actually, it just "parses" any resulting records, of any type, into that record type. So you need to explicitly filter on type in your call to db.find().
It's possible this will be changed in relational-pouch, so I put a comment in the code describing it as a workaround. See these threads for discussion of the same issue:
pouchdb-community/ember-pouch#168
pouchdb-community/ember-pouch#194
cc @HospitalRun/core-maintainers