Skip to content

Commit

Permalink
Instruct CodeCov not to analyze generated TypeScript definitions.
Browse files Browse the repository at this point in the history
Summary: This directory is over 3300 lines of purely type definitions, and is tanking our coverage metric for the `src/ui/src` directory. Our coverage is indeed low, but it isn't 24% like CodeCov thinks right now. The `codecov.yml` file is merged at runtime into the upstream config (currently blank/defaults), so this does not clobber anything.

Test Plan: This is, unfortunately, a YOLO change: to test it, we have to land it, wait for Phab to propagate it to GitHub, and then see what happens when next CodeCov runs against `main`.

Reviewers: michelle, zasgar, #engineering

Reviewed By: michelle, zasgar, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D7043

GitOrigin-RevId: f5135c8
  • Loading branch information
NickLanam committed Jan 6, 2021
1 parent f712179 commit cc09419
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
ignore:
- "src/ui/src/types/generated"

0 comments on commit cc09419

Please sign in to comment.