Skip to content

Commit

Permalink
[build] Fix coverage on remote (pixie-io#1422)
Browse files Browse the repository at this point in the history
Summary: Fix coverage build when running on remote executors.

Type of change: /kind test-infra

Test Plan: Tested that `./ci/collect_coverage` works now

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
  • Loading branch information
JamesMBartlett authored Jun 2, 2023
1 parent ede66ef commit 2f043f0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -266,3 +266,6 @@ build:remote --jobs=100
test:remote --jobs=100
build:remote --nolegacy_important_outputs
build:remote --build_metadata=VISIBILITY=PUBLIC
coverage:remote --strategy=CoverageReport=local,remote
coverage:remote --experimental_fetch_all_coverage_outputs
coverage:remote --experimental_split_coverage_postprocessing
2 changes: 1 addition & 1 deletion ci/collect_coverage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ cd $(bazel info workspace)
bazel coverage --remote_download_outputs=all --combined_report=lcov //src/...

# Copy the output file
cp "$(bazel info output_path)/_coverage/_coverage_report.dat" ${COVERAGE_FILE}
cp --no-preserve=mode "$(bazel info output_path)/_coverage/_coverage_report.dat" ${COVERAGE_FILE}

# Print out the summary.
lcov --summary ${COVERAGE_FILE}
Expand Down

0 comments on commit 2f043f0

Please sign in to comment.