Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] TMAP-API 수정 + login 작업 수정 #26

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Conversation

jinjoo-lab
Copy link
Collaborator

@jinjoo-lab jinjoo-lab commented Sep 25, 2023

추가/수정한 기능 설명

  1. TMAP - API 수정 (테스트 완료)
  2. ResponseEntity 수정 (경로 값 추출 완료)

특이사항

경로 Repo 추가 필요
Login 작업 수정 필요

check list

  • 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했나요?
  • 추가/수정사항을 설명했나요?

Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 LGTM

@Getter
@NoArgsConstructor
@AllArgsConstructor
public class Feature {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 어떤 정보를 담는거야? 클래스명만 보면 기능 요론 느낌이라서 헷갈림

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이게 json 에 feature라 되있어서 .... 걍 클래스 명을 저렇게 함 구조가 보면 좌표하고 type이 같이 들어가 있는 Geometry 클래스를 한번더 type하고 감싼 걸 feature라 하더라고....

@jinjoo-lab jinjoo-lab merged commit de1b076 into master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants