[FEAT] naver maps api fix #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohksj77
reviewed
Aug 31, 2023
|
|
||
| @Primary | ||
| @Bean | ||
| public ObjectMapper KakaoObjectMapper() { |
| @Bean | ||
| public ObjectMapper objectMapper() { | ||
| public ObjectMapper NaverObjectMapper() { |
|
|
||
| /*response 변경*/ | ||
| @PostMapping("/search") | ||
| SearchPathResponse searchPath(@RequestBody SearchPathRequest request) { |
| @AllArgsConstructor | ||
| public class RouteUnitEnt { | ||
| Summary summary; | ||
| List<Double[]> path; |
There was a problem hiding this comment.
dto들에 전반적으로 private이 없는 부분들 확인해줘!
| private final String toSmall; | ||
|
|
||
| public String toSmallFuel() { | ||
| return this.toSmall; |
There was a problem hiding this comment.
이거 근데 this.toString().toLowerCase(); 하면 toSmall 없어도 되는거 아닌가? 아래 enum에도 그렇구
다른 뜻이 있었으면 알려조
| TRAAVOIDCARONLY("자동차 전용도로 회피 우선", "traavoidcaronly"); | ||
|
|
||
| private final String toKorean; | ||
| private final String toSmall; |
| import org.springframework.stereotype.Service; | ||
|
|
||
| @Service | ||
| public class PathService { | ||
| private final PathClient<SearchPathRequest, SearchPathResponse> client; | ||
|
|
||
| PathService(PathClient<SearchPathRequest, SearchPathResponse> client) { |
jinjoo-lab
force-pushed
the
feat/naver-maps-api-fix
branch
from
37568e3
to
e1d0d8a
Compare
jinjoo-lab
force-pushed
the
feat/naver-maps-api-fix
branch
from
2f4e4b4
to
8b59944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가/수정한 기능 설명
특이사항
check list