-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] naver maps api fix #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
|
||
@Primary | ||
@Bean | ||
public ObjectMapper KakaoObjectMapper() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메서드니까 소문자로 시작해조
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 완료
@Bean | ||
public ObjectMapper objectMapper() { | ||
public ObjectMapper NaverObjectMapper() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 완료
|
||
/*response 변경*/ | ||
@PostMapping("/search") | ||
SearchPathResponse searchPath(@RequestBody SearchPathRequest request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResponseEntity랑 접근지정자 써주면 될듯!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 이걸 수정 안했네
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 완료
@AllArgsConstructor | ||
public class RouteUnitEnt { | ||
Summary summary; | ||
List<Double[]> path; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dto들에 전반적으로 private이 없는 부분들 확인해줘!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옼
private final String toSmall; | ||
|
||
public String toSmallFuel() { | ||
return this.toSmall; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 근데 this.toString().toLowerCase(); 하면 toSmall 없어도 되는거 아닌가? 아래 enum에도 그렇구
다른 뜻이 있었으면 알려조
TRAAVOIDCARONLY("자동차 전용도로 회피 우선", "traavoidcaronly"); | ||
|
||
private final String toKorean; | ||
private final String toSmall; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 말한거야
import org.springframework.stereotype.Service; | ||
|
||
@Service | ||
public class PathService { | ||
private final PathClient<SearchPathRequest, SearchPathResponse> client; | ||
|
||
PathService(PathClient<SearchPathRequest, SearchPathResponse> client) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
접근지정자 확인 부탁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 완료
37568e3
to
e1d0d8a
Compare
2f4e4b4
to
8b59944
Compare
추가/수정한 기능 설명
특이사항
check list