do not show IDN message for normal ascii hostnames

HoneyryderChuck · Nov 19, 2020 · c8663e5 · c8663e5
1 parent 777ab21
commit c8663e5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -25,6 +25,7 @@ And also:
 * HTTP/2 Server Push
 * H2C Upgrade
 * Automatic follow redirects
+* International Domain Names
 
 ## How
 

diff --git a/lib/httpx/resolver/https.rb b/lib/httpx/resolver/https.rb
@@ -98,9 +98,7 @@ def resolve(connection = @connections.first, hostname = nil)
 
       if hostname.nil?
         hostname = connection.origin.host
-        if hostname != connection.origin.non_ascii_hostname
-          log { "resolver: resolve IDN #{connection.origin.non_ascii_hostname} as #{hostname}" }
-        end
+        log { "resolver: resolve IDN #{connection.origin.non_ascii_hostname} as #{hostname}" } if connection.origin.non_ascii_hostname
       end
       type = @_record_types[hostname].first
       log { "resolver: query #{type} for #{hostname}" }

diff --git a/lib/httpx/resolver/native.rb b/lib/httpx/resolver/native.rb
@@ -240,9 +240,7 @@ def resolve(connection = @connections.first, hostname = nil)
 
       if hostname.nil?
         hostname = connection.origin.host
-        if hostname != connection.origin.non_ascii_hostname
-          log { "resolver: resolve IDN #{connection.origin.non_ascii_hostname} as #{hostname}" }
-        end
+        log { "resolver: resolve IDN #{connection.origin.non_ascii_hostname} as #{hostname}" } if connection.origin.non_ascii_hostname
       end
       @queries[hostname] = connection
       type = @_record_types[hostname].first