Delete last rpath when requested #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting the first rpath is a good default because it mirrors the behaviour of `install_name_tool`. However, it's not useful behaviour when deleting duplicate rpaths, because it changes the order in which the runtime paths are searched. We delete duplicate rpaths in `brew`, so being able to delete the last instance of the requested rpath instead of the first one would be useful. Co-authored-by: William Woodruff <william@yossarian.net>
woodruffw
approved these changes
Jul 25, 2023
|
Thanks @carlocab! I'll queue up a release now. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the first rpath is a good default because it mirrors the behaviour of
install_name_tool. However, it's not useful behaviour when deleting duplicate rpaths, because it changes the order in which the runtime paths are searched.We delete duplicate rpaths in
brew, so being able to delete the last instance of the requested rpath instead of the first one would be useful.