Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added overcommit and loosened Rubocop for tests #435

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Added overcommit and loosened Rubocop for tests #435

merged 4 commits into from
Jan 18, 2022

Conversation

rickmark
Copy link
Contributor

This adds overcommit to perform local Rubocop before accepting a git commit reducing the amount of PR thrash

It also loosens rules in the test directory to reflect the accepted conventions

rickmark
rickmark commented Jan 15, 2022
View reviewed changes
test/test_fat.rb Outdated Show resolved Hide resolved
rickmark
rickmark commented Jan 15, 2022
View reviewed changes
Copy link
Contributor Author

@rickmark rickmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some details to shorten the loop

Missing element is setup for overcommit which should be added to README

.overcommit.yml Show resolved Hide resolved
.rubocop.yml Show resolved Hide resolved
Gemfile Show resolved Hide resolved
Gemfile Show resolved Hide resolved
@woodruffw woodruffw self-requested a review January 16, 2022 03:41
@rickmark
Copy link
Contributor Author

This should override any simplecov as the updates are not to the covered ruby lines

@woodruffw
Copy link
Member

Missing element is setup for overcommit which should be added to README

Mind doing this as part of this PR as well? Otherwise LGTM!

@rickmark
Copy link
Contributor Author

Missing element is setup for overcommit which should be added to README

Mind doing this as part of this PR as well? Otherwise LGTM!

Will do, copying from https://github.com/hack-different/apple-knowledge/blob/main/README.md basically

woodruffw
woodruffw reviewed Jan 18, 2022
View reviewed changes
README.md Show resolved Hide resolved
@woodruffw
Copy link
Member

N.B.: We probably also want the CI rules updated to reflect that the development Gemfile group shouldn't be installed, i.e. something like bundle install <current args> --without development.

@woodruffw
Copy link
Member

Okay, LGTM! I'll take care of the CI in a follow-up.

@woodruffw woodruffw merged commit b955d08 into Homebrew:master Jan 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@woodruffw woodruffw woodruffw left review comments

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickmark @woodruffw