Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macho): Silence the call to codesign #283

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix(macho): Silence the call to codesign #283

merged 1 commit into from
Nov 6, 2020

Conversation

woodruffw
Copy link
Member

Replaces system with Open3.capture3 to collect codesign's output and error streams.

@woodruffw
fix(macho): Silence the call to codesign
aa6a77d 
Replaces `system` with `Open3.capture3` to collect `codesign`'s
output and error streams.
mistydemeo
mistydemeo approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works, silently, while still raising MachO::CodeSigningError when signing fails.

@woodruffw woodruffw merged commit a95996e into master Nov 6, 2020
@woodruffw woodruffw deleted the ww/hush-codesign branch November 6, 2020 18:33
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodruffw @mistydemeo @BrewTestBot