-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
llvm: enable clang and rtti by default, simplifying deps #48462
Conversation
9 tests failed?
Is this because
If so, thoughts on making |
Seems fine 👍 |
Amended to make |
Failures again. The CI is a timeout, but Jenkins has real failures.
The
I'll look in to them. |
The |
Could be the issue is that the From the llvm formula's caveats:
Looks like this is a known issue: #47149, #47858. Going to read through those and see if I can understand it better. Related, putting in a PR to enable verbose builds for |
This allows all core dependencies on llvm to be on the default llvm, instead of using 'with-rtti' or 'with-clang', which cause a 1-hour+ build from source.
Closing this out as a rejection/withdrawal. Seems to me that there are some nontrivial issues here with the C++ standards support and C++ library builds here, which need someone who's really familiar with them to sort out. And that's not me: even if I could get everything to build here, working on this PR has given me enough familiarity with LLVM and C++ libs to know that I'm not qualified to give a thumbs-up on a change like this. |
Looks like this might be the default in formula for newer versions of The core PR for 3.8 leaves them as options though: #47824 |
This allows all core dependencies on
llvm
to be on the default llvm, instead of using 'with-rtti' or 'with-clang', which cause a 1-hour+ build from source and timeouts on the CI. Follows discussion in #47269.Affected formulae:
I'm omitting
emacs-clang-complete-async
from this PR because it lacks atest do
and will cause the audit checks to fail, and I'd like this to go green. I'll fix it up separately if and when this is merged.I don't think this requires a revision bump to any of the dependent formulae, because they use
llvm
as an external command and don't require a rebuild. (Except maybedoxygen
?)