phantomjs 2.0.1 #47908
phantomjs 2.0.1 #47908
Conversation
Use Vitallium's fork temporarily until 2.1.0 gets released.
| def install | ||
| system "./build.sh", "--confirm", "--jobs", ENV.make_jobs, | ||
| "--qt-config", "-openssl-linked" | ||
| inreplace "src/qt/preconfig.sh", "QT_CFG+=' -openssl -openssl-linked'", |
There was a problem hiding this comment.
I'm not sure if this is something that needs to be fixed upstream; is there a way to pass the OpenSSL flags via build.sh?
There was a problem hiding this comment.
It may be worth investigating if we can use -no-openssl -securetransport but that can be in a future PR.
There was a problem hiding this comment.
Our build script can detect OpenSSL libraries and headers automatically now. Right now we have support for OpenSSL installed via brew or via Mac Ports. See here https://github.com/Vitallium/phantomjs/blob/master/build.py#L45 for more information.
if you want to pass additional arguments to qtconfig, you can use --qt-config command line argument. There is no needs to preconfig.sh. It's obsolete.
|
Great work here @dunn. Merged as-is because I know how much people are clamoring for this. Comments could be touched upon in a future PR. |
| "--qt-config", "-openssl-linked" | ||
| inreplace "src/qt/preconfig.sh", "QT_CFG+=' -openssl -openssl-linked'", | ||
| "QT_CFG+=' -openssl -openssl-linked -I #{Formula["openssl"].opt_include} -L #{Formula["openssl"].opt_lib}'" | ||
| system "./build.sh", "--confirm", "--jobs", ENV.make_jobs |
There was a problem hiding this comment.
We don't have build.sh anymore. We switched to the unified Python script to build PhantomJS.
cc @MikeMcQuaid @vitallium