This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
llvm: Split libc++/libc++abi into separate options #47381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of some path oddities when libc++ is built with libc++abi. See #47149
|
I'm not sure I understand how splitting fixes the issues that were discussed? |
|
Yeah, this was a mistake on my part. Based on the libc++abi website, I thought that libc++abi should build fine on its own, so keeping it would be preferable to leave the option of building it open to users. It looks like libc++abi still needs the libc++ sources, so this wouldn't work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of some path oddities when libc++ is built with libc++abi. See
#47149
Related to #47213; I just think splitting is preferable.