rust: Add --with-llvm option #44138
rust: Add --with-llvm option #44138
Conversation
ghost
mentioned this pull request
|
I've kicked this off our CI for now. We don't test non-default options so the changes in this PR wouldn't actually be reviewed. |
| @@ -31,8 +31,11 @@ class Rust < Formula | |||
| sha256 "04f68ef26b4ca636b35be1d17ad2b641727bbc10cec52582a9e3a64b5784dbeb" => :mavericks | |||
| end | |||
|
|
|||
| option "with-llvm", "Build with brewed LLVM" | |||
There was a problem hiding this comment.
Should we call this with-brewed-llvm (like the git formula does), to make sure users don't think that otherwise somehow their Rust won't have LLVM at all?
There was a problem hiding this comment.
Yes, that sounds much more clear. In the new commit the option is renamed and a better explanation of the option is added.
There was a problem hiding this comment.
I think actually with-llvm makes more sense and we should move more formulae to use that approach.
There was a problem hiding this comment.
Yeah. We can always make the description as it was, to be explicit about the brewed element. I really dislike if build.with? style dependencies.
There was a problem hiding this comment.
Oh right, that way we can just do depends_on "llvm" => :optional. Sounds good.
There was a problem hiding this comment.
I have now uploaded a new commit that changes the option name back to --with-llvm, and keeps the more descriptive description.
ghost
changed the title
--with-llvm allows Homebrew's LLVM to be used instead of Rust's LLVM.
ghost
changed the title
|
ping |
|
Thanks for the nudge. Merged in 4cd4135. Thank you for your contribution to Homebrew @dtrebbien! 😺 |
--with-llvm allows Homebrew's LLVM to be used instead of Rust's LLVM.