Skip to content

Commit

Permalink
formulae_dependents: install all built bottles
Browse files Browse the repository at this point in the history
Fixes CI failure seen at Homebrew/homebrew-core#191307.

I think this is a much cleaner fix for this, but I'll need a bit more
time to work it out. In the meantime, let's do this to unblock the
aforementioned PR.
  • Loading branch information
carlocab committed Sep 20, 2024
1 parent e84b3dd commit 2722273
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions lib/tests/formulae_dependents.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class FormulaeDependents < TestFormulae
attr_writer :testing_formulae, :tested_formulae

def run!(args:)
installable_bottles = @tested_formulae - @skipped_or_failed_formulae
unneeded_formulae = @tested_formulae - @testing_formulae
@skipped_or_failed_formulae += unneeded_formulae

Expand All @@ -18,7 +19,7 @@ def run!(args:)

@dependent_testing_formulae = sorted_formulae - skipped_or_failed_formulae

install_formulae_if_needed_from_bottles!(args:)
install_formulae_if_needed_from_bottles!(installable_bottles, args:)

artifact_specifier = if OS.linux?
"{linux,ubuntu}"
Expand All @@ -40,8 +41,8 @@ def run!(args:)

private

def install_formulae_if_needed_from_bottles!(args:)
@dependent_testing_formulae.each do |formula_name|
def install_formulae_if_needed_from_bottles!(installable_bottles, args:)
installable_bottles.each do |formula_name|
formula = Formulary.factory(formula_name)
next if formula.latest_version_installed?

Expand Down

0 comments on commit 2722273

Please sign in to comment.