Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: update Lima guide #97182

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

AkihiroSuda
Copy link
Contributor

The new form might be easier to use.
The old form is still valid.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The new form might be easier to use.
The old form is still valid.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 18, 2022
@SMillerDev
Copy link
Member

It says

If you don't have Docker installed:

Would docker context use lima still work in that case?

@AkihiroSuda
Copy link
Contributor Author

It says

If you don't have Docker installed:

Would docker context use lima still work in that case?

Yes, because we are installing docker (CLI) formula in the guide.

@MikeMcQuaid MikeMcQuaid merged commit 0b56e4d into Homebrew:master Mar 21, 2022
@MikeMcQuaid
Copy link
Member

Thanks @AkihiroSuda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants