Skip to content

jsoncpp 1.9.5 #92195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

jsoncpp 1.9.5 #92195

wants to merge 11 commits into from

Conversation

@pthariensflame
Copy link
Contributor

@pthariensflame pthariensflame commented Dec 29, 2021

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 29, 2021
@cho-m cho-m added the revision bumps needed Reverse dependencies need to have their revision incremented in the same PR label Dec 31, 2021
@Moisan Moisan force-pushed the bump-jsoncpp-1.9.5 branch from 0d3f9b4 to f31dafb Compare January 1, 2022 19:24
@iMichka iMichka added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 3, 2022
@iMichka iMichka force-pushed the bump-jsoncpp-1.9.5 branch from 7d68556 to de68ccc Compare January 4, 2022 06:15
@branchvincent branchvincent removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jan 8, 2022
@SMillerDev
Copy link
Member

SMillerDev commented Jan 8, 2022

Redex doesn't build at all, for unrelated reasons it seems. I'd suggest just merging this.

CC @iMichka

@github-actions github-actions bot removed the stale No recent activity label Jan 8, 2022
carlocab
carlocab previously approved these changes Jan 8, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jan 10, 2022
@carlocab carlocab removed the stale No recent activity label Jan 10, 2022
@iMichka
Copy link
Member

iMichka commented Jan 10, 2022

I have a fix for redex: #92848
Let's wait and rebase once it is merged.

@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 11, 2022
@iMichka iMichka force-pushed the bump-jsoncpp-1.9.5 branch from c82dde0 to 9a45467 Compare January 11, 2022 21:51
@iMichka
Copy link
Member

iMichka commented Jan 11, 2022

Rebased and running with long-ci label.

@pthariensflame
Copy link
Contributor Author

pthariensflame commented Jan 12, 2022

Why was libxslt affected???

carlocab
carlocab previously approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we merge this. libsbol can (probably) be fixed by adding a depends_on "libxslt", which we can do shortly after merging this. It's probably not worth re-running CI here for it, since libsbol only builds on Catalina now.

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 12, 2022
@carlocab
Copy link
Member

carlocab commented Jan 12, 2022

Why was libxslt affected???

It doesn't seem to be. How was it affected?

@iMichka
Copy link
Member

iMichka commented Jan 12, 2022 •
edited
Loading 

==> brew linkage --test libsbol
==> FAILED
Full linkage --test libsbol output
  Broken dependencies:
    /usr/local/opt/libxslt/lib/libxslt.1.dylib (libxslt)

Only on 10.15. Weird. Probably opportunistic linkage.

@carlocab
Copy link
Member

carlocab commented Jan 12, 2022 •
edited
Loading

Only on 10.15.

libsbol doesn't build anywhere else

@iMichka
Copy link
Member

iMichka commented Jan 12, 2022

And here is the fix for libsbol: #92994

@SMillerDev SMillerDev added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 13, 2022
@carlocab
Copy link
Member

carlocab commented Jan 13, 2022

Only on 10.15.

libsbol doesn't build anywhere else

Now it builds everywhere. Thanks @iMichka

@iMichka
Copy link
Member

iMichka commented Jan 13, 2022

All green. I like that :)

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 13, 2022
@BrewTestBot
Copy link
Member

BrewTestBot commented Jan 13, 2022

🤖 A scheduled task has triggered a merge.

@scpeters scpeters mentioned this pull request Jan 13, 2022
Closed
@pthariensflame pthariensflame deleted the bump-jsoncpp-1.9.5 branch January 13, 2022 22:08
@scpeters scpeters mentioned this pull request Jan 21, 2022
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age revision bumps needed Reverse dependencies need to have their revision incremented in the same PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pthariensflame @SMillerDev @iMichka @carlocab @BrewTestBot @branchvincent @cho-m @Moisan